-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Devtools] Ensure initial read of useFormStatus
returns NotPendingTransition
#28728
Merged
eps1lon
merged 3 commits into
facebook:main
from
eps1lon:formstatus-no-transition-config
Aug 1, 2024
Merged
[Devtools] Ensure initial read of useFormStatus
returns NotPendingTransition
#28728
eps1lon
merged 3 commits into
facebook:main
from
eps1lon:formstatus-no-transition-config
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Apr 3, 2024
This was referenced Apr 3, 2024
eps1lon
force-pushed
the
formstatus-no-transition-config
branch
from
April 3, 2024 12:41
4a90699
to
c4c315f
Compare
Comparing: a7d1240...a3c2f2f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
formstatus-no-transition-config
branch
from
April 3, 2024 20:03
c4c315f
to
592eb8b
Compare
eps1lon
force-pushed
the
formstatus-no-transition-config
branch
from
April 15, 2024 21:14
592eb8b
to
fa7c1dd
Compare
eps1lon
commented
Apr 15, 2024
eps1lon
force-pushed
the
formstatus-no-transition-config
branch
2 times, most recently
from
April 16, 2024 08:28
5a943b2
to
ffc4b05
Compare
sebmarkbage
approved these changes
Jul 30, 2024
eps1lon
force-pushed
the
formstatus-no-transition-config
branch
from
July 31, 2024 16:50
ffc4b05
to
9261a50
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eps1lon
force-pushed
the
formstatus-no-transition-config
branch
from
July 31, 2024 16:52
9261a50
to
f117368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29788
Stack:
useFormStatus
returnsNotPendingTransition
#28728 <--- You're hereSummary
We couldn't initialize the
HostTransitionContext
toNotPendingTransition
since that created a dependency cycle. By moving the wholeHostTransitionContext
into the Fiber config, we no longer have a dependency cycle and can initialize the context to the config specificNotPendingTransition
value.Flow should ensure every Fiber config implements
HostTransitionContext
properly. It's just a bit annoying since it duplicates config boilerplate.An incorrect initial value in Devtools would be bad since it probably makes any component not inspectable if you destructure the form status i.e.
const {isPending} = useFormStatus()
since you'd try to destructurenull
when we inspect the component.